Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useless Reline::Key.new and update wrong comment for alt+d #963

Merged
merged 1 commit into from
Jun 4, 2024
+4 −3
Merged

Remove useless Reline::Key.new and update wrong comment for alt+d #963

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions lib/irb/input-method.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,10 +328,11 @@ def show_doc_dialog_proc
->() {
dialog.trap_key = nil
alt_d = [
[Reline::Key.new(nil, 0xE4, true)], # Normal Alt+d.
[27, 100], # Normal Alt+d when convert-meta isn't used.
[195, 164], # The "ä" that appears when Alt+d is pressed on xterm.
[226, 136, 130] # The "∂" that appears when Alt+d in pressed on iTerm2.
# When option/alt is not configured as a meta key in terminal emulator,
# option/alt + d will send a unicode character depend on OS keyboard setting.
[195, 164], # "ä" in somewhere (FIXME: environment information is unknown).
[226, 136, 130] # "∂" Alt+d on Mac keyboard.
]

if just_cursor_moving and completion_journey_data.nil?
Expand Down
Loading