Always use alternate sceen on alt-d #988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tompng
force-pushed
the
alternate_screen
branch
from
09d89af to
966c490
Compare
st0012
reviewed
Oct 11, 2024
| begin | ||
| print "\e[?1049h" |
There was a problem hiding this comment.
Is this something we want ri to do most of the time as well?
|
IRB's pager and in ri command, I think we don't need to use this escape sequence. |
st0012
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes screen corruption when
PAGER=moreis used.When ALT+D is pressed while showing document dialog, document in shown in full screen using pager.
IRB assumes that the pager switches to alternate screen, turns off alternate screen at exit, and restore IRB's screen.
Some pager like
moredoes not do that. Screen corrupts. We need to switch to alternate screen manually.To reproduce:
PAGER=more irb(make suremoreis not aliased toless)PAGER="sh -c 'cat;sleep 1'" irb