Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instantiate Parser with a kwsplat #652

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Instantiate Parser with a kwsplat #652

merged 1 commit into from
Oct 25, 2024

Conversation

byroot
Copy link
Member

@byroot byroot commented Oct 25, 2024

Prior to 2.7.3, JSON::Ext::Parser would only take kwargs. So if json_pure 2.7.4 is loaded with json <= 2.7.2 (or stdlib) it blows up.

Ref: #650
Fix: #651

cc @Hohlen

NB: make sure this doesn't throw warnings in 2.7 or older.

@byroot
Instantiate Parser with a kwsplat
4af0ea5 
Prior to 2.7.3, `JSON::Ext::Parser` would only take kwargs.
So if json_pure 2.7.4 is loaded with `json <= 2.7.2` (or stdlib)
it blows up.

Ref: ruby#650
Fix: ruby#651
@byroot byroot merged commit 04b43d2 into ruby:v2.7.x Oct 25, 2024
73 checks passed
@byroot byroot deleted the v2.7.x-pure-compat branch October 25, 2024 17:29
@byroot byroot mentioned this pull request Oct 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@byroot