-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement talking SSL to the proxy too #55
Conversation
@@ -1024,7 +1028,13 @@ def connect | |||
debug "opened" | |||
if use_ssl? | |||
if proxy? | |||
plain_sock = BufferedIO.new(s, read_timeout: @read_timeout, | |||
if @proxy_use_ssl | |||
proxy_sock = OpenSSL::SSL::SSLSocket.new(s) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this probably needs some more work, especially when it comes to verification etc, but it's a start :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@evgeni, I try to avoid code changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what you mean by that?
Would be good if someone, like @peterzhu2118 or @BurdetteLamar can leave a commit for this change? |
c1310af
to
726803c
Compare
👍 |
Thanks! |
net-http version 0.5.0 finally introduced TLS proxy support: ruby/net-http#55 https://github.com/ruby/net-http/releases/tag/v0.5.0
net-http version 0.5.0 finally introduced TLS proxy support: ruby/net-http#55 https://github.com/ruby/net-http/releases/tag/v0.5.0
* Add HTTPS Proxy support net-http version 0.5.0 finally introduced TLS proxy support: ruby/net-http#55 https://github.com/ruby/net-http/releases/tag/v0.5.0 * Add mininum net-http version SSL proxies only supported in net-http 0.5.0 or above
https://bugs.ruby-lang.org/issues/16482