Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement talking SSL to the proxy too #55

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Conversation

evgeni
Copy link
Contributor

@evgeni evgeni commented May 9, 2022

@@ -1024,7 +1028,13 @@ def connect
debug "opened"
if use_ssl?
if proxy?
plain_sock = BufferedIO.new(s, read_timeout: @read_timeout,
if @proxy_use_ssl
proxy_sock = OpenSSL::SSL::SSLSocket.new(s)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this probably needs some more work, especially when it comes to verification etc, but it's a start :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evgeni, I try to avoid code changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what you mean by that?

@sbernhard
Copy link

Would be good if someone, like @peterzhu2118 or @BurdetteLamar can leave a commit for this change?

@hsbt hsbt merged commit 227ed00 into ruby:master Jul 11, 2024
22 checks passed
@hsbt
Copy link
Member

hsbt commented Jul 11, 2024

👍

@evgeni
Copy link
Contributor Author

evgeni commented Jul 11, 2024

Thanks!

@evgeni evgeni deleted the ssl-proxies branch July 11, 2024 09:46
richardmarbach added a commit to richardmarbach/faraday-net_http that referenced this pull request Nov 11, 2024
net-http version 0.5.0 finally introduced TLS proxy support: ruby/net-http#55
https://github.com/ruby/net-http/releases/tag/v0.5.0
richardmarbach added a commit to richardmarbach/faraday-net_http that referenced this pull request Nov 11, 2024
net-http version 0.5.0 finally introduced TLS proxy support: ruby/net-http#55
https://github.com/ruby/net-http/releases/tag/v0.5.0
olleolleolle pushed a commit to lostisland/faraday-net_http that referenced this pull request Nov 11, 2024
* Add HTTPS Proxy support

net-http version 0.5.0 finally introduced TLS proxy support: ruby/net-http#55
https://github.com/ruby/net-http/releases/tag/v0.5.0

* Add mininum net-http version

SSL proxies only supported in net-http 0.5.0 or above
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants