Support 3.5 for version option #3336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kddnewton
force-pushed
the
support-3-5-version
branch
from
9b79d58 to
6b6aa05
Compare
|
@kddnewton Currently there are bunch of versions comparisons like Line 2969 in 3c4851c I think they are correct because all conditions use PM_OPTIONS_VERSION_CRUBY_3_3 (and it is the lowest version) and none use 3_4/LATEST (which would most likely result in a bug) but it feels brittle. WDYT about giving enum values that increase with newer versions? (e.g. 3.3 = 33, 3.4 = 34, latest = 99) That way one could do e.g. parser->version >= PM_OPTIONS_VERSION_CRUBY_3_4 instead of parser->version != PM_OPTIONS_VERSION_CRUBY_3_3, which seems a lot clearer about intent (behavior for 3.4+).
|
koic
added a commit
to koic/prism
that referenced
this pull request
Dec 25, 2024
Follow up ruby#3336. Development for Ruby 3.5 has begun on the master branch: ruby/ruby@2f064b3
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Dec 26, 2024
Follow up ruby/prism#3336. Development for Ruby 3.5 has begun on the master branch: 2f064b3 ruby/prism@aa49c1bd78
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.