Fix an incompatibility with the parser translator #3338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The offset cache contains an entry for each byte so it can't be accessed via the string length. Adds tests for all variants except for this: ``` "fo o" "ba ’" ``` For some reason, this still has the wrong offset.
Earlopain
force-pushed
the
parser-translator-offset-cache
branch
from
72909b4 to
a651126
Compare
kddnewton
approved these changes
Dec 21, 2024
|
Actually, I think the reason why that other test I wanted to add doesn't work is for the same reason as #2539 (comment) In isolation the test works but when there is more than one multi-byte character it breaks. The offset is not correct when there were previous multibyte characters in the file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For rubocop/rubocop#12982
The offset cache contains an entry for each byte so it can't be accessed via the string length. For
’the bytesize is 3, so it's two bytes off. Adds tests for all variants except for this:For some reason, this still has the wrong offset. Also, one test fails in
RubyParserbut that is certainly out of my area of expertise.