Fix parser translator simplifying strings when it shouldn't #3340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example this: ```rb _buf << ': ' ``` Prism currently converts `tSTRING_BEG` => `tSTRING_CONTENT` => `tSTRING_END` into a simple `tSTRING` token. But, the parser gem doesn't do that when the string content ends with a newline. Note that this is only an issue for strings spanning only two lines. When there are more lines, there are two `tSTRING_CONTENT` tokens so it falls through.
kddnewton
approved these changes
Dec 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example this:
Prism currently converts
tSTRING_BEG=>tSTRING_CONTENT=>tSTRING_ENDinto a simpletSTRINGtoken.But, the parser gem doesn't do that when the string content ends with a newline.
Note that this is only an issue for strings spanning only two lines. When there are more lines, there are two
tSTRING_CONTENTtokens so it falls through.