Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support error_on_expect_mismatch declaration in Racc grammar file #262

Merged
merged 1 commit into from
May 17, 2024

Conversation

yui-knk
Copy link
Contributor

@yui-knk yui-knk commented Apr 29, 2024

expect warns the difference between expected S/R conflicts count
and actual count however racc command exits with success.
racc command will exit with failure if error_on_expect_mismatch declaration
is specified therefore build process of racc user will also fail.

@yui-knk yui-knk force-pushed the support_expect_bang branch from bd7384e to 40f7b94 Compare April 30, 2024 09:33
@yui-knk
Copy link
Contributor Author

yui-knk commented May 7, 2024

I will change to implement error_on_expect_mismatch declaration to manage exit code instead of expect! declaration.

`expect` warns the difference between expected S/R conflicts count
and actual count however racc command exits with success.
racc command will exit with failure if `error_on_expect_mismatch` declaration
is specified therefore build process of racc user will also fail.
@yui-knk yui-knk force-pushed the support_expect_bang branch from 40f7b94 to 8f4ad92 Compare May 17, 2024 02:03
@yui-knk yui-knk changed the title Support expect! declaration in Racc grammar file Support error_on_expect_mismatch declaration in Racc grammar file May 17, 2024
@yui-knk yui-knk merged commit 00ebdbb into ruby:master May 17, 2024
28 checks passed
@yui-knk yui-knk deleted the support_expect_bang branch May 17, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant