Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rb_file_const is not working #1067

Closed
nobu opened this issue Dec 18, 2023 · 0 comments · Fixed by #1069
Closed

rb_file_const is not working #1067

nobu opened this issue Dec 18, 2023 · 0 comments · Fixed by #1069

Comments

@nobu
Copy link
Member

nobu commented Dec 18, 2023

In dir.c, rb_file_const is used to define constants in static rb_mFConst in file.c.

    rb_file_const("FNM_NOESCAPE", INT2FIX(FNM_NOESCAPE));

RDoc::Parser::C#do_constants scans this line, but RDoc::Parser::C#gen_const_table does not support rb_file_const and the document for this line is ignored.

Ditto for rb_curses_define_const.
nobu added a commit to nobu/ruby that referenced this issue Dec 18, 2023
@nobu
[DOC] Add links from File::Constants in dir.c to File constants
4fe1f05 
Due to the bug ruby/rdoc#1067, `rb_file_const` needs `Document-const`
directives.
nobu added a commit to nobu/ruby that referenced this issue Dec 18, 2023
@nobu
[DOC] Add links from File::Constants in dir.c to File constants
494e6b5 
Due to the bug ruby/rdoc#1067, `rb_file_const` needs `Document-const`
directives.
@nobu nobu mentioned this issue Dec 19, 2023
Merged
@nobu nobu closed this as completed in cdad51a Dec 19, 2023
hsbt pushed a commit to hsbt/ruby that referenced this issue Dec 25, 2023
@nobu @hsbt
[ruby/rdoc] Fix support for rb_file_const and rb_curses_define_const
056e032 
Constant definitions using these functions have been supported, but
since RDoc::Parser::C#gen_const_table did not consider other than
`rb_define_const` the documents for them have not been found, without
`Document-const` direvtive.

Fixes ruby/rdoc#1067

ruby/rdoc@cdad51a60b
hsbt pushed a commit to hsbt/ruby that referenced this issue Dec 25, 2023
@nobu @hsbt
[ruby/rdoc] Fix support for rb_file_const and rb_curses_define_const
5a28870 
Constant definitions using these functions have been supported, but
since RDoc::Parser::C#gen_const_table did not consider other than
`rb_define_const` the documents for them have not been found, without
`Document-const` direvtive.

Fixes ruby/rdoc#1067

ruby/rdoc@cdad51a60b
hsbt pushed a commit to hsbt/ruby that referenced this issue Dec 25, 2023
@nobu @hsbt
[ruby/rdoc] Fix support for rb_file_const and rb_curses_define_const
e179997 
Constant definitions using these functions have been supported, but
since RDoc::Parser::C#gen_const_table did not consider other than
`rb_define_const` the documents for them have not been found, without
`Document-const` direvtive.

Fixes ruby/rdoc#1067

ruby/rdoc@cdad51a60b
hsbt pushed a commit to ruby/ruby that referenced this issue Dec 25, 2023
@nobu @hsbt
[ruby/rdoc] Fix support for rb_file_const and rb_curses_define_const
e324953 
Constant definitions using these functions have been supported, but
since RDoc::Parser::C#gen_const_table did not consider other than
`rb_define_const` the documents for them have not been found, without
`Document-const` direvtive.

Fixes ruby/rdoc#1067

ruby/rdoc@cdad51a60b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix support for rb_file_const and rb_curses_define_const nobu/rdoc
1 participant
@nobu