Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use NOBENCHMARK env #447

Merged
merged 1 commit into from
Apr 9, 2017
Merged

Use NOBENCHMARK env #447

merged 1 commit into from
Apr 9, 2017

Conversation

aycabta
Copy link
Member

@aycabta aycabta commented Apr 8, 2017

This Pull Request is modified versions of https://github.com/rdoc/rdoc/pull/446 what was not refined.

The command rake runs tests with benchmark:

$ rake
Run options: --seed 35482

# Running tests:

......(snip)......

Finished tests in 13.490933s, 159.9593 tests/s, 381.0707 assertions/s.

2158 tests, 5141 assertions, 0 failures, 0 errors, 1 skips

# Running benchmarks:


TestRDocContext 1       10      100     1000    10000
bench_add_include        0.000037        0.000052        0.000288        0.003270        0.020100


Finished benchmarks in 0.084059s, 11.8964 tests/s, 11.8964 assertions/s.

1 tests, 1 assertions, 0 failures, 0 errors, 1 skips

The NOBENCHMARK=1 rake runs tests without benchmark:

$ NOBENCHMARK=1 rake
Run options: --seed 274

# Running tests:

......(snip)......

Finished tests in 21.829784s, 98.8558 tests/s, 235.5039 assertions/s.

2158 tests, 5141 assertions, 0 failures, 0 errors, 1 skips

This is easily understandable.

@aycabta aycabta force-pushed the use-nobenchmark-env branch 3 times, most recently from 0f272de to b4491ea Compare April 8, 2017 15:52
@zzak
Copy link
Member

zzak commented Apr 9, 2017

@aycabta Thanks! Could you squash the commits please?

@aycabta aycabta force-pushed the use-nobenchmark-env branch from b4491ea to 4aec798 Compare April 9, 2017 02:04
@aycabta
Copy link
Member Author

aycabta commented Apr 9, 2017

@zzak OK, done.

@zzak zzak merged commit 5f11ddf into ruby:master Apr 9, 2017
@aycabta aycabta deleted the use-nobenchmark-env branch April 9, 2017 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants