Improve ri --help and --version options handling #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicitly handle ri's --help and --version options instead of relying on OptionParser's default behavior. This makes both options appear in the ri --help text. This also fixes `ri -h' which did not work as expected: instead of displaying the help text, ri entered the interactive mode, apparently ignoring the option.
|
My name is Eric Hodel and I approve this pull request (pending CI). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
ri -h, which does not work currently.Instead of showing the help banner, ri apparently ignores the `-h' option (without error message for an unknown option) and starts in interactive mode.
(Also reported at https://bugs.ruby-lang.org/issues/10838.)
Make
--helpand--versionoptions appear in the --help outputVarious small improvements of the
ri --helpoutput