Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for require dynamic string #458

Merged
merged 1 commit into from
Jul 13, 2017

Conversation

aycabta
Copy link
Member

@aycabta aycabta commented Jul 9, 2017

The require dynamic string like below shouldn't be parsed:

prefix = 'path'
require "#{prefix}/a_library"

The require dynamic string like below shouldn't be parsed:

prefix = 'path'
require "#{prefix}/a_library"
@hsbt
Copy link
Member

hsbt commented Jul 13, 2017

I wonder why it is not parsed.

But it's existence behavior. I'm ok to merge this.

@hsbt hsbt merged commit ec49db2 into ruby:master Jul 13, 2017
@aycabta
Copy link
Member Author

aycabta commented Jul 16, 2017

I think the dyanmic string expansion with variable is heavy to parse for RDoc, because RDoc just parses Ruby code but doesn't execute. I guess what this is the reason of the behavior.

Memo: In the first RDoc commit of Ruby trunk at revision 5073, it uses eval for string in arguments. And at eb53cb6 of Git repository, it skips dynamic string in the same method.

@aycabta aycabta deleted the add-test-for-require-dynamic-string branch August 2, 2017 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants