Fix complex condition in for/while/until #480
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
parse_statements method
callsskip_optional_do_after_expression
in case offor
/while
/until
tokens. Theskip_optional_do_after_expression
usesget_end_token
for checking end of loop condition expressions, but it's not correct, because the end is detected by onlydo
token, newline and semi-colon token.For example,
This code is highlighted below:
I think this is broken. This Pull Request fixes it: