Fix postfix if after escaped newline #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the identify_identifier method, if "@lex_state != :EXPR_BEG && @lex_state != :EXPR_FNAME", TkIF becomes TkIF_MOD. So when "\n" comes after escaped backslash, doesn't set :EXPR_BEG to @lex_state with this commit. This commit fixes correctly handling TkIF_MOD after escaped newline.
hsbt
requested changes
Aug 23, 2017
test/test_rdoc_ruby_lex.rb
Outdated
| @@ -591,96 +591,39 @@ def test_class_tokenize_string | |||
| assert_equal expected, tokens | |||
| end | |||
|
|
|||
| def test_class_tokenize_string_with_escape | |||
| def test_class_tokenize_postfix_if_after_escaped_newline | |||
There was a problem hiding this comment.
test_class_tokenize_string_with_escape is needless test case? It seems regression.
…ter-escaped-newline
aycabta
force-pushed
the
fix-postfix-if-after-escaped-newline
branch
from
6e56ab6 to
62418d0
Compare
…ter-escaped-newline
|
I fixed merging what was handled in a rush yesterday. |
…ter-escaped-newline
…ter-escaped-newline
|
I confirmed test-case and your patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
identify_identifiermethod, if@lex_state != :EXPR_BEG && @lex_state != :EXPR_FNAME,TkIFbecomesTkIF_MOD. So when"\n"comes after escaped backslash, doesn't set:EXPR_BEGto@lex_statewith this commit. This commit fixes correctly handlingTkIF_MODafter escaped newline.