Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling embdoc and unnecessary blank line in <pre> #494

Merged
merged 3 commits into from
Aug 22, 2017

Conversation

aycabta
Copy link
Member

@aycabta aycabta commented Aug 14, 2017

In syntax highlighting on documentation, like below, =begin\n and =end are trimmed.

  # document
  #
  #   =begin
  #   test embdoc
  #   =end
  #
  def blah
  end

It's sample code in documentation, so the trimming behavior is a bug. This Pull Request fixes it. And unnecessary blank line behavior in <pre> block is removed.

In syntax highlighting on documentation, like below,
"=begin\n" and "=end" are trimmed.

  # document
  #
  #   =begin
  #   test embdoc
  #   =end
  #
  def blah
  end

It's sample code in documentation,
so the trimming behavior is a bug.
This commit fixes it.
And unnecessary blank line behavior in <pre> block is removed.
@aycabta
Copy link
Member Author

aycabta commented Aug 14, 2017

This Pull Request depends on #485.

@hsbt hsbt self-assigned this Aug 15, 2017
@hsbt
Copy link
Member

hsbt commented Aug 22, 2017

I heard this pull request fixes rdoc documentation. It's so useful changes.

@hsbt hsbt merged commit 71b01e3 into ruby:master Aug 22, 2017
@aycabta aycabta deleted the fix-handling-embdoc branch August 22, 2017 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants