Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed useless method related RubyToken. #539

Merged
merged 1 commit into from
Oct 12, 2017
Merged

Removed useless method related RubyToken. #539

merged 1 commit into from
Oct 12, 2017

Conversation

hsbt
Copy link
Member

@hsbt hsbt commented Oct 10, 2017

@hsbt hsbt requested a review from aycabta October 10, 2017 06:17
aycabta
aycabta approved these changes Oct 11, 2017
View reviewed changes
Copy link
Member

@aycabta aycabta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's important and correct removal.

@aycabta
Copy link
Member

aycabta commented Oct 11, 2017

And I added a commit to remove comment against RubyLex and RubyToken, to master branch directly because it's just a comment.

@hsbt hsbt merged commit 7255613 into master Oct 12, 2017
@hsbt hsbt deleted the remove-useless-method branch October 12, 2017 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aycabta aycabta aycabta approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsbt @aycabta