Don't use lex_state emulation on Ruby 2.5 or later #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RDoc::RipperStateLex has InnerStateLex that is emulation layer about lex_state of parse.y, but after Ruby 2.5 or later, Ripper gives lex_state value as state method inside Ripper::Filter's callback. On this commit, uses the new feature of Ripper on Ruby 2.5 or later.
hsbt
reviewed
Oct 24, 2017
lib/rdoc/parser/ripper_state_lex.rb
Outdated
| @@ -1,6 +1,9 @@ | |||
| require 'ripper' | |||
|
|
|||
| class RDoc::RipperStateLex | |||
| # TODO: Remove this constants after Ruby 2.4 EOL | |||
| RIPPER_HAS_LEX_STATE = (RUBY_VERSION >= '2.5.0') | |||
There was a problem hiding this comment.
Should we use respond_to? instead of RUBY_VERSION ?
aycabta
force-pushed
the
remove-lex_state-emulation-on-ruby25
branch
from
55d568d to
ee9d50a
Compare
|
OK, I'll use |
hsbt
reviewed
Nov 7, 2017
| @@ -1,6 +1,9 @@ | |||
| require 'ripper' | |||
|
|
|||
| class RDoc::RipperStateLex | |||
| # TODO: Remove this constants after Ruby 2.4 EOL | |||
| RIPPER_HAS_LEX_STATE = Ripper::Filter.method_defined?(:state) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RDoc::RipperStateLexhasInnerStateLexthat is emulation layer aboutlex_stateof parse.y, but after Ruby 2.5 or later,Rippergiveslex_statevalue asstatemethod insideRipper::Filter's callback. On this Pull Request, uses the new feature ofRipperon Ruby 2.5 or later.