Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Regexp 'General Category' classes for windows #566

Closed
wants to merge 1 commit into from

Conversation

MSP-Greg
Copy link
Contributor

See Ruby Core issue 14137.

I checked \p{Blank}, and it does match 'fractional' Unicode space characters.

Before PR, I tested on Appveyor with ruby 2.2 thru trunk, and all failed; last passing test done was at beta2. This PR passed here on Appveyor.

@aycabta Thanks for the PR's over in YARD. I build https://msp-greg.github.io/ daily (or more) with trunk, so I'm catching many of the Ripper changes, as YARD is pretty stable and doesn't have a lot or PR's or commits...

@MSP-Greg MSP-Greg changed the title Remove 'General Category' classes for windows Remove Regexp 'General Category' classes for windows Nov 28, 2017
@MSP-Greg
Copy link
Contributor Author

MSP-Greg commented Dec 3, 2017

Please do not accept this PR. I investigated further, it is really a Ruby / Windows encoding issue that goes back to at least Ruby 2.0. I submitted PR evanphx/kpeg#37 for it.

Since the code that affects the running kpeg gem is minimal, I added a commit MSP-Greg@d89e07b to my rdoc fork that applies the patch before testing (assumes kpeg v1.1.0).

The Appveyor results pass for ruby 2.2 thru trunk. Note that the results without the change fail for all versions.

If anyone is interested (I'm aware this just affects building the gem on windows, not installing or using it), I'm not sure if it works for windows users who are not using the default encoding of IBM437...

Thanks, Greg

@MSP-Greg MSP-Greg closed this Dec 3, 2017
@MSP-Greg MSP-Greg deleted the literals branch December 5, 2017 14:26
@aycabta
Copy link
Member

aycabta commented Dec 8, 2017

OK, I got the picture and thank you for your detailed investigation. I wait for that KPeg's issue is resolved by that the Pull Request is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants