Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove needless json dependency #574

Merged
merged 3 commits into from
Jan 30, 2018
Merged

Remove needless json dependency #574

merged 3 commits into from
Jan 30, 2018

Conversation

hsbt
Copy link
Member

@hsbt hsbt commented Dec 24, 2017

It provides on all support versions.

@hsbt hsbt force-pushed the remove-needless-json branch from d935cd0 to bd30482 Compare December 24, 2017 00:11
@hsbt hsbt force-pushed the remove-needless-json branch from bd30482 to c19b2b7 Compare December 24, 2017 00:26
@aycabta
Copy link
Member

aycabta commented Dec 25, 2017

I don't understand why CI fails...I'm surveying the reason.

@hsbt
Copy link
Member Author

hsbt commented Dec 25, 2017

Yes, It's very strange. I investigate too.

@rhenium
Copy link
Member

rhenium commented Dec 25, 2017

I added that in commit 82e352e so I could use bundle exec rake test to run rdoc's test suite. Later, as of commit 63b455a, .travis.yml also started to use bundle exec.

As in the commit message, I needed json as a development dependency (just) because RubyGems' rubygems/test_case (which test/test_rdoc_rubygems_hook.rb does require) wants to activate the json gem explicitly. I didn't know why rubygems/test_case does that in the first place, though.

@hsbt
Copy link
Member Author

hsbt commented Dec 26, 2017

@rhenium Thanks for your clarification!

@aycabta
Copy link
Member

aycabta commented Dec 26, 2017

The 08b23dd added RDoc::RubygemsHook that is ported from lib/rubygems/rdoc.rb of RubyGems (ref. rubygems/rubygems@33060f7). It depends on Gem::UserInteraction of RubyGems. As @rhenium said, RubyGems needs json gem explicitly. Therefore, RDoc depends on json gem via RubyGems.

I don't know the story so far about the porting.

@hsbt
Copy link
Member Author

hsbt commented Jan 30, 2018

JRuby test failure was caused by autoload. We should fix it another pull request.

@hsbt hsbt merged commit 5e3bafb into master Jan 30, 2018
@hsbt hsbt deleted the remove-needless-json branch January 30, 2018 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants