Fix method line number #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RDoc::Encoding.read_file removes magic comments, after that, Ruby parser processes the content. So method line number is reduced by the amount of the magic comment lines. This commit fixes it by that changes the behavior of RDoc::Encoding.read_file to not remove magic comments. This closes ruby#425.
This commit removes magic comments from documents and keeps correct line number.
aycabta
force-pushed
the
fix-method-line-no
branch
from
972fe7f to
8b3b256
Compare
|
I added 8b3b256, it removes magic comments from documents and keeps correct line number. I checked all CRuby documents between with this branch and without this branch. There are only fixed line numbers differences (you can check it by my check tool). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RDoc::Encoding.read_fileremoves magic comments, after that, Ruby parser processes the content. So method line number is reduced by the amount of the magic comment lines.This commit fixes it by that changes the behavior of
RDoc::Encoding.read_fileto not remove magic comments.This closes #425.
...But please wait for merging, this branch outputs strange documents. I'll add some commits to this branch later.