Ignore constants discovered in passing #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RDoc::Parser::Ruby#parse_constant registers nested constants automatically. For example, it registers module 'A' and 'B' with A::B::C. Second, constant 'C' is registered if assign token '=' comes. This logic automatically registers 'A' and 'B' if assign token doesn't come. This commit fixes it.
RDoc::Context#add_module_alias registers module alias only when original module found, but the original modules are sometimes registered in other files. This commit fixes it with lazy registration module alias.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #209 and #298.
ref. rails/rails#14150
I confirmed this patch to keep original behavior for all CRuby documents.