Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Place expression next line of else #675

Merged
merged 1 commit into from
Dec 6, 2018
Merged

Place expression next line of else #675

merged 1 commit into from
Dec 6, 2018

Conversation

nobu
Copy link
Member

@nobu nobu commented Dec 2, 2018

It is not a bug, but very confusing when multiple lines block follows.

aycabta
aycabta approved these changes Dec 2, 2018
View reviewed changes
Copy link
Member

@aycabta aycabta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that the patch doesn't change the behavior for whole CRuby's document.

@nobu nobu force-pushed the bug/misplaced-expression branch from e3f13bb to 67ac2a6 Compare December 4, 2018 13:17
@nobu
Place expression next line of else
0c23002 
It is not a bug, but very confusing when multiple lines block
follows.
@nobu nobu force-pushed the bug/misplaced-expression branch from 67ac2a6 to 0c23002 Compare December 5, 2018 00:22
@aycabta aycabta merged commit f744a93 into ruby:master Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aycabta aycabta aycabta approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nobu @aycabta