Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape method names in HTML #762

Merged
merged 1 commit into from
Apr 5, 2020

Conversation

natematykiewicz
Copy link
Contributor

@natematykiewicz natematykiewicz commented Apr 5, 2020

The following is invalid HTML:

<a href="Array.html#method-i-3C-3C"><code><<</code></a></p>

Incorrect:

<code><<</code>

Correct:

<code>&lt;&lt;</code>

Fixes #761

The following is invalid HTML:
<a href="Array.html#method-i-3C-3C"><code><<</code></a></p>

Incorrect:
<code><<</code>

Correct:
<code>&lt;&lt;</code>

Fixes ruby#761
@ioquatix ioquatix merged commit b120d08 into ruby:master Apr 5, 2020
@ioquatix ioquatix added this to the v6.2.2 milestone Apr 5, 2020
@ioquatix
Copy link
Member

ioquatix commented Apr 5, 2020

@hsbt is it possible to do bug fix release?

@hsbt
Copy link
Member

hsbt commented Apr 6, 2020

I can release it.

@aycabta Can you do cut of release with this fix?

@ioquatix
Copy link
Member

ioquatix commented Apr 6, 2020

Also, FYI, current ruby doc website has this error. So it should be updated too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Invalid HTML being generated.
3 participants