Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed inadvertent environment variable changes #766

Merged
merged 2 commits into from
Apr 24, 2020
Merged

Fixed inadvertent environment variable changes #766

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
00fb4dd
Should teardown in reverse order of setup
nobu Apr 24, 2020
6c4801d
HOME is preserved by RDoc::TestCase
nobu Apr 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions test/rdoc/test_rdoc_markdown.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@
class TestRDocMarkdown < RDoc::TestCase

def setup
super

@RM = RDoc::Markup

@parser = RDoc::Markdown.new
Expand Down
2 changes: 2 additions & 0 deletions test/rdoc/test_rdoc_parser_changelog.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ def setup

def teardown
@tempfile.close!

super
end

def test_class_can_parse
Expand Down
6 changes: 2 additions & 4 deletions test/rdoc/test_rdoc_ri_driver.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ def setup
FileUtils.mkdir_p @home_ri

@orig_ri = ENV['RI']
@orig_home = ENV['HOME']
ENV['HOME'] = @tmpdir
@rdoc_home = File.join ENV["HOME"], ".rdoc"
FileUtils.mkdir_p @rdoc_home
Expand All @@ -33,11 +32,10 @@ def setup
end

def teardown
super

ENV['HOME'] = @orig_home
ENV['RI'] = @orig_ri
FileUtils.rm_rf @tmpdir

super
end

DUMMY_PAGER = ":;\n"
Expand Down
4 changes: 2 additions & 2 deletions test/rdoc/test_rdoc_ri_paths.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,12 +36,12 @@ def setup
end

def teardown
super

Gem.use_paths(*@orig_gem_path)
Gem::Specification.reset
FileUtils.rm_rf @tempdir
ENV.replace(@orig_env)

super
end

def test_class_each
Expand Down