Relative loading for easier development #821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch makes sure we only load relative code. Hence when coding or testing rdoc, we'll be sure to always be using the correct code. Discussion started at #817. Signed-off-by: Ulysse Buonomo <buonomo.ulysse@gmail.com>
BuonOmo
commented
Jun 30, 2021
Remove Rakefile lib folder to make sure we test that usage of relative paths Signed-off-by: Ulysse Buonomo <buonomo.ulysse@gmail.com>
|
Needs nobu/rdoc@02fa391. |
|
@nobu shall I apply the patch you linked, or is in your hands? |
|
Please apply. |
|
@nobu done :) |
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Feb 12, 2022
This patch makes sure we only load relative code. Hence when coding or testing rdoc, we'll be sure to always be using the correct code. Discussion started at ruby/rdoc#817. Signed-off-by: Ulysse Buonomo <buonomo.ulysse@gmail.com> ruby/rdoc@aa41bd48eb Co-authored-by: Nobuyoshi Nakada <nobu@ruby-lang.org>
nobu
added a commit
to nobu/rdoc
that referenced
this pull request
Nov 27, 2022
Since also the template files are searched from the `$LOAD_PATH`, the current library should not be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes sure we only load relative code. Hence when coding or
testing rdoc, we'll be sure to always be using the correct code.
Discussion started at #817.
There is one place I did not change
requireforrequire_relative, that is underexe/because I don't know how that is handled by rubygem, and guessed it could be copied. Moreover, there are no related tests.I almost went and created a helper
autoload_relativemethod, but I guess I'll let that for ruby core at some point.The second commit acts as a test for that new behavior, it may feel intrusive. In that case I'll revert that bit