Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for --template-stylesheets option #829

Merged
merged 1 commit into from
Sep 3, 2021
Merged

Add tests for --template-stylesheets option #829

merged 1 commit into from
Sep 3, 2021
+33 −6

Conversation

nobu
Copy link
Member

@nobu nobu commented Aug 18, 2021

Fixes #205
Fixes #828 too

olleolleolle
olleolleolle reviewed Aug 18, 2021
View reviewed changes
Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome fast fix!

@nobu
Add tests for --template-stylesheets option
857002a 
Also flattens `@options.template_stylesheets` when parsing the
command lines.

Fixes ruby#205
Fixes ruby#828 too
@nobu nobu force-pushed the fix-template-stylesheets branch from 1f14e44 to 857002a Compare August 18, 2021 04:58
olleolleolle
olleolleolle approved these changes Aug 18, 2021
View reviewed changes
Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳 Celebrate this fix! 🥳

@hsbt hsbt merged commit 2f7dfec into ruby:master Sep 3, 2021
@nobu nobu deleted the fix-template-stylesheets branch September 3, 2021 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olleolleolle olleolleolle olleolleolle approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

darkfish raises with --template-stylesheets option
3 participants
@nobu @olleolleolle @hsbt