Skip to content

Commit

Permalink
Merge pull request #1023 from AI-Mozi/deconstruct_keys_specs_for_date
Browse files Browse the repository at this point in the history
Add `deconstruct_keys` for `Date` and `DateTime` and `Time`
  • Loading branch information
andrykonchin authored May 11, 2023
2 parents e19f670 + 8719340 commit 624c7aa
Show file tree
Hide file tree
Showing 3 changed files with 132 additions and 0 deletions.
44 changes: 44 additions & 0 deletions core/time/deconstruct_keys_spec.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
require_relative '../../spec_helper'

ruby_version_is "3.2" do
describe "Time#deconstruct_keys" do
it "returns whole hash for nil as an argument" do
d = Time.utc(2022, 10, 5, 13, 30)
res = { year: 2022, month: 10, day: 5, yday: 278, wday: 3, hour: 13,
min: 30, sec: 0, subsec: 0, dst: false, zone: "UTC" }
d.deconstruct_keys(nil).should == res
end

it "returns only specified keys" do
d = Time.utc(2022, 10, 5, 13, 39)
d.deconstruct_keys([:zone, :subsec]).should == { zone: "UTC", subsec: 0 }
end

it "requires one argument" do
-> {
Time.new(2022, 10, 5, 13, 30).deconstruct_keys
}.should raise_error(ArgumentError)
end

it "it raises error when argument is neither nil nor array" do
d = Time.new(2022, 10, 5, 13, 30)

-> { d.deconstruct_keys(1) }.should raise_error(TypeError, "wrong argument type Integer (expected Array or nil)")
-> { d.deconstruct_keys("asd") }.should raise_error(TypeError, "wrong argument type String (expected Array or nil)")
-> { d.deconstruct_keys(:x) }.should raise_error(TypeError, "wrong argument type Symbol (expected Array or nil)")
-> { d.deconstruct_keys({}) }.should raise_error(TypeError, "wrong argument type Hash (expected Array or nil)")
end

it "returns {} when passed []" do
Time.new(2022, 10, 5, 13, 30).deconstruct_keys([]).should == {}
end

it "ignores non-Symbol keys" do
Time.new(2022, 10, 5, 13, 30).deconstruct_keys(['year', []]).should == {}
end

it "ignores not existing Symbol keys" do
Time.new(2022, 10, 5, 13, 30).deconstruct_keys([:year, :a]).should == { year: 2022 }
end
end
end
43 changes: 43 additions & 0 deletions library/date/deconstruct_keys_spec.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
require_relative '../../spec_helper'
require 'date'

ruby_version_is "3.2" do
describe "Date#deconstruct_keys" do
it "returns whole hash for nil as an argument" do
d = Date.new(2022, 10, 5)
d.deconstruct_keys(nil).should == { year: 2022, month: 10, day: 5, yday: 278, wday: 3 }
end

it "returns only specified keys" do
d = Date.new(2022, 10, 5)
d.deconstruct_keys([:year, :month]).should == { year: 2022, month: 10 }
end

it "requires one argument" do
-> {
Date.new(2022, 10, 5).deconstruct_keys
}.should raise_error(ArgumentError)
end

it "it raises error when argument is neither nil nor array" do
d = Date.new(2022, 10, 5)

-> { d.deconstruct_keys(1) }.should raise_error(TypeError, "wrong argument type Integer (expected Array or nil)")
-> { d.deconstruct_keys("asd") }.should raise_error(TypeError, "wrong argument type String (expected Array or nil)")
-> { d.deconstruct_keys(:x) }.should raise_error(TypeError, "wrong argument type Symbol (expected Array or nil)")
-> { d.deconstruct_keys({}) }.should raise_error(TypeError, "wrong argument type Hash (expected Array or nil)")
end

it "returns {} when passed []" do
Date.new(2022, 10, 5).deconstruct_keys([]).should == {}
end

it "ignores non-Symbol keys" do
Date.new(2022, 10, 5).deconstruct_keys(['year', []]).should == {}
end

it "ignores not existing Symbol keys" do
Date.new(2022, 10, 5).deconstruct_keys([:year, :a]).should == { year: 2022 }
end
end
end
45 changes: 45 additions & 0 deletions library/datetime/deconstruct_keys_spec.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
require_relative '../../spec_helper'
require 'date'

ruby_version_is "3.2" do
describe "DateTime#deconstruct_keys" do
it "returns whole hash for nil as an argument" do
d = DateTime.new(2022, 10, 5, 13, 30)
res = { year: 2022, month: 10, day: 5, yday: 278, wday: 3, hour: 13,
min: 30, sec: 0, sec_fraction: (0/1), zone: "+00:00" }
d.deconstruct_keys(nil).should == res
end

it "returns only specified keys" do
d = DateTime.new(2022, 10, 5, 13, 39)
d.deconstruct_keys([:zone, :hour]).should == { zone: "+00:00", hour: 13 }
end

it "requires one argument" do
-> {
DateTime.new(2022, 10, 5, 13, 30).deconstruct_keys
}.should raise_error(ArgumentError)
end

it "it raises error when argument is neither nil nor array" do
d = DateTime.new(2022, 10, 5, 13, 30)

-> { d.deconstruct_keys(1) }.should raise_error(TypeError, "wrong argument type Integer (expected Array or nil)")
-> { d.deconstruct_keys("asd") }.should raise_error(TypeError, "wrong argument type String (expected Array or nil)")
-> { d.deconstruct_keys(:x) }.should raise_error(TypeError, "wrong argument type Symbol (expected Array or nil)")
-> { d.deconstruct_keys({}) }.should raise_error(TypeError, "wrong argument type Hash (expected Array or nil)")
end

it "returns {} when passed []" do
DateTime.new(2022, 10, 5, 13, 30).deconstruct_keys([]).should == {}
end

it "ignores non-Symbol keys" do
DateTime.new(2022, 10, 5, 13, 30).deconstruct_keys(['year', []]).should == {}
end

it "ignores not existing Symbol keys" do
DateTime.new(2022, 10, 5, 13, 30).deconstruct_keys([:year, :a]).should == { year: 2022 }
end
end
end

0 comments on commit 624c7aa

Please sign in to comment.