Add specs for argument coercion (#to_int, #to_str) in Signal

[herwinw]

No description provided.

[andrykonchin]

suggestion: I would check also that Signal.list["HUP"] returns Integer but not some other type:

hup = Signal.list["HUP"]
hup.should.is_a?(Integer)

[herwinw]

The file list_spec.rb contains these two tests:

it "includes the EXIT key with a value of zero" do
  Signal.list["EXIT"].should == 0
end

it "includes the KILL key with a value of nine" do
  Signal.list["KILL"].should == 9
end

I would guess the return type is covered here.

[andrykonchin]

It may help to maintain this test case in future (and make it more readable) as for me. As a reader I may not remember what Signal.list returns at all and explicit check just makes the value type explicit. But it's a subjective topic of course.

[andrykonchin]

Could you please squash commits and I will merge the PR then?

[herwinw]

Could you please squash commits and I will merge the PR then?

They're squashed into 1 commit. Only 9 more review to go, I'll try to have a look at them somewhere this week.

[andrykonchin]

Thank you!