Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add specs for IO.open to close the file descriptor if block raises #1082

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Add specs for IO.open to close the file descriptor if block raises #1082

merged 1 commit into from
Sep 25, 2023

Conversation

herwinw
Copy link
Member

@herwinw herwinw commented Sep 25, 2023

It did have some checks if the close operation raises, but not what happens if the block itself raises an exception.

@herwinw
Add specs for IO.open to close the file descriptor if block raises
0ae44d9 
It did have some checks if the close operation raises, but not what
happens if the block itself raises an exception.
@andrykonchin
Copy link
Member

Thank you!

@andrykonchin andrykonchin merged commit 42ff6ab into ruby:master Sep 25, 2023
10 checks passed
@herwinw herwinw deleted the io_open_close_after_exception branch September 25, 2023 10:10
@herwinw herwinw mentioned this pull request Sep 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@herwinw @andrykonchin