Add specs for compare methods of OpenSSL #1107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrykonchin
approved these changes
Nov 12, 2023
| input1 = "the quick brown fox jumps over the lazy dog" | ||
| input2 = "the lazy dog jumps over the quick brown fox" | ||
| OpenSSL.fixed_length_secure_compare(input1, input2).should be_false | ||
| end |
There was a problem hiding this comment.
suggestion: it also makes sense to illustrate that length is bytes count, not characters count (as far as I see in the implementation)
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very crude spec that just checks to see if the results are correct. These methods have the guarantee to run in constant time regardless of the input, which is not under test.