Extra specs for YAML output #1114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This output differs from the named Struct objects by omitting the
":#{class}" part.
The spec that was described as "YAML of a Class object" actually tested an instance of a Class, update this description.
andrykonchin
approved these changes
Nov 18, 2023
| @@ -13,10 +13,18 @@ | |||
| { "a" => "b"}.to_yaml.should match_yaml("--- \na: b\n") | |||
| end | |||
|
|
|||
| it "returns the YAML representation of a Class object" do | |||
| it "returns the YAML representation of an object" do | |||
| @@ -59,6 +67,11 @@ | |||
| Person.new("Jane", "female").to_yaml.should match_yaml("--- !ruby/struct:Person\nname: Jane\ngender: female\n") | |||
| end | |||
|
|
|||
| it "returns the YAML representation of an unnamed Struct object" do | |||
There was a problem hiding this comment.
Suggested change
| it "returns the YAML representation of an unnamed Struct object" do | |
| it "returns the YAML representation of an unnamed Struct subclass object" do |
|
Thank you! |
|
TBH I find spec titles in this file a bit misleading because a term "object" is used. As for me "instance" term is more correct. For instance in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.