Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert globals in YAML specs to constants #1118

Merged
merged 2 commits into from
Dec 4, 2023
Merged

Convert globals in YAML specs to constants #1118

merged 2 commits into from
Dec 4, 2023

Conversation

herwinw
Copy link
Member

@herwinw herwinw commented Dec 2, 2023

No description provided.

eregon
eregon approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@eregon eregon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eregon eregon merged commit 3006e4a into ruby:master Dec 4, 2023
10 checks passed
@herwinw herwinw deleted the yaml_globals branch December 4, 2023 18:21
herwinw added a commit to herwinw/natalie that referenced this pull request Dec 4, 2023
@herwinw
Refresh YAML specs
f7fd69d 
This replaces some globals with constants

Upstream fix: ruby/spec#1118
@herwinw herwinw mentioned this pull request Dec 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eregon eregon eregon approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@herwinw @eregon