Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix description of specs of UNIXSocket.pair #1130

Merged
merged 1 commit into from
Jan 28, 2024

Conversation

herwinw
Copy link
Member

@herwinw herwinw commented Jan 26, 2024

This is a class method, not an instance method.

This is a class method, not an instance method.
@eregon
Copy link
Member

eregon commented Jan 26, 2024

@herwinw Given your many great PRs & contributions I would like to give you write access to ruby/spec. And then you can merge simple PRs like this yourself or even directly push to master.

@hsbt Could you add @herwinw to the Ruby organization? Then I can add him to the rubyspec-committers team.

@hsbt
Copy link
Member

hsbt commented Jan 26, 2024

@eregon I send an invitation to @herwinw directly joining rubyspec-committers team.

@eregon
Copy link
Member

eregon commented Jan 27, 2024

@herwinw Welcome to ruby/spec committers! Please merge this PR yourself :)

@herwinw herwinw merged commit e36cbdc into ruby:master Jan 28, 2024
10 checks passed
@herwinw herwinw deleted the unixsocket_pair branch January 28, 2024 19:32
@herwinw
Copy link
Member Author

herwinw commented Jan 28, 2024

Nailed it 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants