Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split multibyte class names from Marshal fixtures into their own file #1198

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

herwinw
Copy link
Member

@herwinw herwinw commented Oct 3, 2024

This removes the dependency on module_eval. It does use the magic comment to force the file encoding, but that one is present in the main fixture as well.

This removes the dependency on module_eval. It does use the magic
comment to force the file encoding, but that one is present in the main
fixture as well.
@andrykonchin
Copy link
Member

Yeah, makes sense. Thank you!

@andrykonchin andrykonchin merged commit 2bfa245 into ruby:master Oct 3, 2024
14 checks passed
@andrykonchin
Copy link
Member

The only concern I have is that a file in the fixtures directory requires another sibling file. I would place the new file into a subdirectory. Actually the spec/ruby/core/marshal/fixtures/marshal_data.rb file's content is what usually stored in classes.rb files (in <class>Spec module).

@herwinw herwinw deleted the marshal_utf8_names branch October 3, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants