Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix upstreamed specs (Dec 2024) #1226

Merged
merged 3 commits into from
Dec 9, 2024

Conversation

andrykonchin
Copy link
Member

No description provided.

@andrykonchin andrykonchin force-pushed the ak/debug-failing-specs branch 2 times, most recently from b8a240e to 5f6459f Compare December 9, 2024 16:43
@andrykonchin andrykonchin force-pushed the ak/debug-failing-specs branch from 5f6459f to 8ff5cfd Compare December 9, 2024 17:04
@andrykonchin andrykonchin force-pushed the ak/debug-failing-specs branch from 8ff5cfd to 5900f86 Compare December 9, 2024 17:13

platform_is :windows do
SystemCallError.new(-1).message.should == "The operation completed successfully."
end
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Observed strange behaviour on Windows. CRuby calls strerror on Windows to get a string description for errno and it returns unexpected strings for unsupported errno codes (e.g. negative or not listed in https://learn.microsoft.com/en-us/cpp/c-runtime-library/errno-constants)

@andrykonchin andrykonchin changed the title Debug default error messages on Windows Fix upstreamed specs (Dec 2024) Dec 9, 2024
@andrykonchin andrykonchin force-pushed the ak/debug-failing-specs branch from 095e1e2 to 5900f86 Compare December 9, 2024 18:01

io.path.should == "a.txt"
io.path.should == "a.txt"
end
Copy link
Member Author

@andrykonchin andrykonchin Dec 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By some reason specs fail on macOS/Ubintu on CI with error:

-----------------------------------------------------
The rubyspec temp directory is not empty. Ensure that
all specs are cleaning up temporary files:
  /Users/runner/work/spec/spec/rubyspec_temp/[59](https://github.com/ruby/spec/actions/runs/12241512394/job/34146769462?pr=1226#step:9:60)61
-----------------------------------------------------


1)
An exception occurred during: after :each
C-API IO function rb_io_open_descriptor sets the specified path ERROR
Errno::EBADF: Bad file descriptor @ fptr_finalize_flush - /Users/runner/work/spec/spec/rubyspec_temp/59[61](https://github.com/ruby/spec/actions/runs/12241512394/job/34146769462?pr=1226#step:9:62)/110-c_api_io_specs
/Users/runner/work/spec/spec/optional/capi/io_spec.rb:218:in `close'
/Users/runner/work/spec/spec/optional/capi/io_spec.rb:218:in `block (2 levels) in <top (required)>'
/Users/runner/work/spec/spec/optional/capi/io_spec.rb:205:in `<top (required)>'

Cannot reproduce it locally. So I decided just to quarantine them until the issue is investigated.

https://github.com/ruby/spec/actions/runs/12241512394/job/34146769462
https://github.com/ruby/spec/actions/runs/12241608299/job/34147078428

@andrykonchin andrykonchin force-pushed the ak/debug-failing-specs branch from d1edff6 to 749826e Compare December 9, 2024 18:12
@andrykonchin andrykonchin merged commit 9f10222 into ruby:master Dec 9, 2024
14 checks passed
@andrykonchin andrykonchin deleted the ak/debug-failing-specs branch December 9, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant