adds spec Kernel#open is not redefined by open-uri #887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moofkit
force-pushed
the
openuri_not_redefine
branch
from
73fe4dc to
6aa1e7f
Compare
eregon
reviewed
Oct 27, 2021
core/kernel/open_spec.rb
Outdated
| platform_is :windows do | ||
| out.should include("Errno::EINVAL") | ||
| out.should include("Invalid argument @ rb_sysopen - http://www.ruby-lang.org/ ") | ||
| end |
There was a problem hiding this comment.
I think a simpler way (if we use a subprocess anyway) would be to check this way:
before = Kernel.instance_method(:open)
require 'open-uri'
after = Kernel.instance_method(:open)
p before == afterAnd then the output should be "true\n".
That way we don't rely on whatever the internal error for Kernel#open is.
Could you change to that?
There was a problem hiding this comment.
I was wondering how to do something like that. And your proposal is very clear and simple. Thanks!
moofkit
force-pushed
the
openuri_not_redefine
branch
from
6aa1e7f to
80c903a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solving #823
I'm not sure this is correct location of spec but have found other example at this place and think that they should be together.