Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ruby 3.1: Add specs for ERB.new #961

Merged
merged 1 commit into from
Oct 17, 2022
Merged

Ruby 3.1: Add specs for ERB.new #961

merged 1 commit into from
Oct 17, 2022

Conversation

ohbarye
Copy link
Contributor

@ohbarye ohbarye commented Oct 16, 2022

Issue

A part of #923

Change

This pull request adds a spec for Feature #14256. ERB.new warns deprecation when passed safe_level and later arguments.

@ohbarye ohbarye force-pushed the add-spec-for-erb-arguments-warning branch from dc0ea97 to 5149ac9 Compare October 16, 2022 12:55
eregon
eregon approved these changes Oct 17, 2022
View reviewed changes
Copy link
Member

@eregon eregon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eregon eregon merged commit a9bdae8 into ruby:master Oct 17, 2022
@ohbarye ohbarye deleted the add-spec-for-erb-arguments-warning branch October 17, 2022 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eregon eregon eregon approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ohbarye @eregon