Don't move the timer_thread when it's enclosed #24 #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eregon
reviewed
Feb 14, 2023
gamecreature
force-pushed
the
feature/handling-enclosed-threadgroups
branch
2 times, most recently
from
4c130e3 to
27f27d5
Compare
Don't move the timer_thread to ThreadGroup::Default, when it's created in an enclosed ThreadGroup. Prevents the exception: "add" can't move from the enclosed thread group"
gamecreature
force-pushed
the
feature/handling-enclosed-threadgroups
branch
from
27f27d5 to
3bcf3bb
Compare
eregon
force-pushed
the
feature/handling-enclosed-threadgroups
branch
from
850abeb to
126d3e0
Compare
eregon
approved these changes
Feb 15, 2023
|
Much better with this simplification! |
|
@hsbt Hello, could you make a release of timeout with this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't move the timer_thread to ThreadGroup::Default, when it's created in an enclosed ThreadGroup.
Prevents the exception: "add" can't move from the enclosed thread group"
Fixes #24.