Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

icon proposal #74

Merged
merged 1 commit into from
Nov 6, 2022
Merged

icon proposal #74

merged 1 commit into from
Nov 6, 2022

Conversation

firien
Copy link
Contributor

@firien firien commented Nov 5, 2022

I do not consider myself an artist, so I will take no offense if you reject this.
The blue marker inside is supposed to be the standard (ish) breakpoint icon.

image

@ko1
Copy link
Collaborator

ko1 commented Nov 5, 2022

Sorry, i couldn't understand how the proposed icon is used on your screenshot. 8 line blue marker? (but it is different with icon.png)

@firien
Copy link
Contributor Author

firien commented Nov 5, 2022

the proposed icon is just a generic ruby image with breakpoint inside it.
image

@firien firien changed the title icon suggestion icon proposal Nov 5, 2022
@firien firien force-pushed the icon branch 3 times, most recently from a8e82e8 to c6157b8 Compare November 5, 2022 22:20
@firien
Copy link
Contributor Author

firien commented Nov 5, 2022

I centered it a little better and rebased

@firien
Copy link
Contributor Author

firien commented Nov 5, 2022

oh and the icon is only used in the extension gallery
image
and probably on the marketplace website

@ko1
Copy link
Collaborator

ko1 commented Nov 6, 2022

Ah, I misunderstood it changes the editor's breakpoint line icons (editor's face), but it changes the face of extension.

Let me check about them:

  • how to treat the copyright of the icon? (I'm not sure the license about this kind of artwork)
  • In future I want to prepare the icon of debug.gem and I think it should be similar. Do you mind to change it if it is available? (or making this icon as a debug.gem's logo is one idea)

@firien
Copy link
Contributor Author

firien commented Nov 6, 2022

  • how to treat the copyright of the icon? (I'm not sure the license about this kind of artwork)

I just threw it together; I waive any copyright claims.

  • In future I want to prepare the icon of debug.gem and I think it should be similar. Do you mind to change it if it is available? (or making this icon as a debug.gem's logo is one idea)

Feel free to use as you wish. I will close this PR (so it doesn't linger around) but I will keep firien:icon branch around if you want to use (or expand on) this icon in the future.

@firien firien closed this Nov 6, 2022
@ko1
Copy link
Collaborator

ko1 commented Nov 6, 2022

Thank you. I'll add your name in README as an author of icon.

@ko1 ko1 reopened this Nov 6, 2022
@ko1 ko1 merged commit 1b889dc into ruby:master Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants