Add the overwrite_arrays option #103
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @dtaniwaki, this is a great idea! Implementation wise, PR #110 has just been merged in - we now use the gem version of |
|
@fredwu |
|
@dtaniwaki Thanks for trying to update your pull request. Maybe you can use test cases added by me. I updated my branch to rewrite test cases with rspec Note I have not updated my implementation. I leave it up to you. |
Fryguy
added a commit
to Fryguy/deep_merge
that referenced
this pull request
Apr 1, 2016
This is an extraction from rubyconfig/config#103 where @dtaniwaki had added this option, but had done it prior to the deep_merge extraction. Paired with @carbonin <https://github.com/carbonin> on this.
Fryguy
added a commit
to Fryguy/config
that referenced
this pull request
Apr 1, 2016
This is an extraction from rubyconfig#103 where @dtaniwaki had added this option, but had done it prior to the deep_merge extraction. This depends on danielsdeleo/deep_merge#21 Paired with @carbonin <https://github.com/carbonin> on this.
Fryguy
added a commit
to Fryguy/deep_merge
that referenced
this pull request
Apr 1, 2016
This is an extraction from rubyconfig/config#103 where @dtaniwaki had added this option, but had done it prior to the deep_merge extraction. Paired with @carbonin <https://github.com/carbonin> on this.
Fryguy
added a commit
to Fryguy/config
that referenced
this pull request
Apr 1, 2016
This is an extraction from rubyconfig#103 where @dtaniwaki had added this option, but had done it prior to the deep_merge extraction. This depends on danielsdeleo/deep_merge#21 Paired with @carbonin <https://github.com/carbonin> on this.
Fryguy
added a commit
to Fryguy/deep_merge
that referenced
this pull request
Apr 1, 2016
This is an extraction from rubyconfig/config#103 where @dtaniwaki had added this option, but had done it prior to the deep_merge extraction. Paired with @carbonin <https://github.com/carbonin> on this.
Fryguy
added a commit
to Fryguy/deep_merge
that referenced
this pull request
May 20, 2016
This is an extraction from rubyconfig/config#103 where @dtaniwaki had added this option, but had done it prior to the deep_merge extraction. Paired with @carbonin <https://github.com/carbonin> on this.
vinceve
pushed a commit
to vinceve/config
that referenced
this pull request
Jul 27, 2016
This is an extraction from rubyconfig#103 where @dtaniwaki had added this option, but had done it prior to the deep_merge extraction. This depends on danielsdeleo/deep_merge#21 Paired with @carbonin <https://github.com/carbonin> on this.
Fryguy
added a commit
to Fryguy/config
that referenced
this pull request
Aug 1, 2016
This is an extraction from rubyconfig#103 where @dtaniwaki had added this option, but had done it prior to the deep_merge extraction. This depends on danielsdeleo/deep_merge#21 Paired with @carbonin <https://github.com/carbonin> on this.
|
Fixed in #137 using newer deep_merge gem |
devs-cloud
pushed a commit
to devs-cloud/ruby-config
that referenced
this pull request
Dec 20, 2019
This is an extraction from rubyconfig/config#103 where @dtaniwaki had added this option, but had done it prior to the deep_merge extraction. This depends on danielsdeleo/deep_merge#21 Paired with @carbonin <https://github.com/carbonin> on this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we should be able to diable merging arrays.
e.g. Let's say you have the default settings like below.
config/settings.ymlAnd for production settings.
config/settings/production.ymlRailsConfigmerges the settings like below.However, I don't want to send email to
foo1@example.comandfoo2@example.comin production. Currently, we don't have any method to achieve this goal. So I just added an option to disable merging arrays.What do you think this idea?