-
-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit max version of dry-validation #223
Changes from 3 commits
43e1842
7cd1876
6c5b6b9
c0e1db6
f14f7a6
6c33d0a
79adc5e
c43b4b5
64d2bb5
21dacff
cac6736
7478377
0a66a43
81dfd00
eadd865
453af70
8cc66b8
a1b3b78
d14affb
effa9c5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
module Config | ||
VERSION = '1.7.1' | ||
VERSION = '1.7.2'.freeze | ||
end |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,8 +17,9 @@ | |
# Require `belongs_to` associations by default. Previous versions had false. | ||
Rails.application.config.active_record.belongs_to_required_by_default = true | ||
|
||
# Removed in rails 5.2+ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This was needed only for tests for Rails 5.0. There is a separate 5.2 folder. So this change should not be required? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It blows up on There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hmm, made some changes. Lets see if build fails. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Totally happy if it's not needed. |
||
# Do not halt callback chains when a callback returns false. Previous versions had true. | ||
ActiveSupport.halt_callback_chains_on_return_false = false | ||
# ActiveSupport.halt_callback_chains_on_return_false = false | ||
|
||
# Configure SSL options to enable HSTS with subdomains. Previous versions had false. | ||
Rails.application.config.ssl_options = { hsts: { subdomains: true } } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should not bump the version.
freeze
is OKThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I figured it needed to be bumped so bundler recognizes a new version when it's pushed. I'm used to doing it myself for work, forgot that might be part of a different process elsewhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will upgrade this whenever the gem will get released. Saying that, I can release once this PR is merged I guess.