Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit max version of dry-validation #223

Merged
merged 20 commits into from
Jun 13, 2019
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions config.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,13 @@ Gem::Specification.new do |s|
s.require_paths = ['lib']
s.required_ruby_version = '>= 2.0.0'

s.add_dependency 'activesupport', '>= 3.0'
s.add_dependency 'deep_merge', '~> 1.2', '>= 1.2.1'
s.add_dependency 'activesupport', '>= 3.0'
s.add_dependency 'deep_merge', '~> 1.2', '>= 1.2.1'
s.add_dependency 'dry-validation', '~> 0.12', '>= 0.12.2', '< 1.0.0' if RUBY_VERSION >= '2.2'

s.add_dependency 'dry-validation', '~> 0.10', '>= 0.10.7' if RUBY_VERSION >= '2.1' && RUBY_VERSION < '2.2'
s.add_dependency 'dry-validation', '~> 0.12', '>= 0.12.2' if RUBY_VERSION >= '2.2'
if RUBY_VERSION >= '2.1' && RUBY_VERSION < '2.2'
s.add_dependency 'dry-validation', '~> 0.10', '>= 0.10.7', '< 1.0.0'
end

s.add_development_dependency 'bundler', '~> 1.13', '>= 1.13.6'
s.add_development_dependency 'rake', '~> 12.0', '>= 12.0.0'
Expand Down
2 changes: 1 addition & 1 deletion lib/config/version.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module Config
VERSION = '1.7.1'
VERSION = '1.7.2'.freeze
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should not bump the version. freeze is OK

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I figured it needed to be bumped so bundler recognizes a new version when it's pushed. I'm used to doing it myself for work, forgot that might be part of a different process elsewhere.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will upgrade this whenever the gem will get released. Saying that, I can release once this PR is merged I guess.

end
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,9 @@
# Require `belongs_to` associations by default. Previous versions had false.
Rails.application.config.active_record.belongs_to_required_by_default = true

# Removed in rails 5.2+
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was needed only for tests for Rails 5.0. There is a separate 5.2 folder. So this change should not be required?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It blows up on rake spec. That must run the wrong combination of directories and versions? I had trouble getting appraisal to work here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, made some changes. Lets see if build fails.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally happy if it's not needed.

# Do not halt callback chains when a callback returns false. Previous versions had true.
ActiveSupport.halt_callback_chains_on_return_false = false
# ActiveSupport.halt_callback_chains_on_return_false = false

# Configure SSL options to enable HSTS with subdomains. Previous versions had false.
Rails.application.config.ssl_options = { hsts: { subdomains: true } }