Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit max version of dry-validation #223

Merged
merged 20 commits into from
Jun 13, 2019
Merged

Limit max version of dry-validation #223

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
43e1842
Limit version of dry-validation as 1.0 is a breaking change
zbelzer Jun 11, 2019
7cd1876
Address code climate issues
zbelzer Jun 11, 2019
6c5b6b9
Code climate, again.
zbelzer Jun 11, 2019
c0e1db6
Update version.rb
pkuczynski Jun 11, 2019
f14f7a6
Update new_framework_defaults.rb
pkuczynski Jun 11, 2019
6c33d0a
Update config.gemspec
pkuczynski Jun 11, 2019
79adc5e
Update config.gemspec
pkuczynski Jun 11, 2019
c43b4b5
Update .rubocop.yml
pkuczynski Jun 11, 2019
64d2bb5
Update config.gemspec
pkuczynski Jun 11, 2019
21dacff
Update .rubocop.yml
pkuczynski Jun 11, 2019
cac6736
Lock in acceptable sqlite version for apps
zbelzer Jun 12, 2019
7478377
Assume that dry-logic needs to be held back too
zbelzer Jun 12, 2019
0a66a43
Fix version restriction syntax
zbelzer Jun 12, 2019
81dfd00
Fix quotes. Try to address 2.1.10 issue
zbelzer Jun 12, 2019
eadd865
Use older version of bundler as default
zbelzer Jun 12, 2019
453af70
Follow instructions here: https://docs.travis-ci.com/user/languages/r…
zbelzer Jun 12, 2019
8cc66b8
Address minor code climate issues
zbelzer Jun 12, 2019
a1b3b78
Update .rubocop.yml
pkuczynski Jun 13, 2019
d14affb
Update CHANGELOG.md
pkuczynski Jun 13, 2019
effa9c5
Update CHANGELOG.md
pkuczynski Jun 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions config.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,9 @@ Gem::Specification.new do |s|

s.add_dependency 'activesupport', '>= 3.0'
s.add_dependency 'deep_merge', '~> 1.2', '>= 1.2.1'

s.add_dependency 'dry-validation', '~> 0.12', '>= 0.12.2', '< 1.0.0' if RUBY_VERSION >= '2.2'

if RUBY_VERSION >= '2.1' && RUBY_VERSION < '2.2'
s.add_dependency 'dry-validation', '~> 0.10', '>= 0.10.7', '< 1.0.0'
end
s.add_dependency 'dry-validation', '~> 0.10', '>= 0.10.7', '< 1.0.0' if RUBY_VERSION >= '2.1' && RUBY_VERSION < '2.2'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code climate complained that this line was too long. This is how I had it originally.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not seem to complain anymore?


s.add_development_dependency 'bundler', '~> 1.13', '>= 1.13.6'
s.add_development_dependency 'rake', '~> 12.0', '>= 12.0.0'
Expand Down