Define the constant on Object instead of Kernel #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing on the bundler version checks
…ng minimum supported versions
…we now only support 2.4+
|
Should this PR be treated as breaking change? |
|
I doubt it will affect to many people but I think it should probably be considered a breaking change. I added it to the changelog as a breaking change, are there other things that need done to flag it that way as well? |
|
I think I would not consider this as a breaking change if it does not affect people in a way they can't use this gem in certain conditions or a certain way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #122
It is branched off of the branch that upgrades the dry-rb gems so once that PR is merged, the changes here are minimal. Basically only config.rb and the changelog are updated.