Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin to sprockets 3 as 4.0 support will require some work (fix tests with rails 4.2) #254

Closed
wants to merge 1 commit into from

Conversation

jrafanie
Copy link
Contributor

See: rails/sprockets-rails#443
and https://github.com/rails/sprockets/blob/master/UPGRADING.md#guide-to-upgrading-from-sprockets-3x-to-4

Note, config gem currently supports rails 4.2+ so it's unclear how easy it will
be to support sprockets 4 and rails 4.2. For now, we can use sprockets 3 and
have tests pass.

See: rails/sprockets-rails#443
and https://github.com/rails/sprockets/blob/master/UPGRADING.md#guide-to-upgrading-from-sprockets-3x-to-4

Note, config gem currently supports rails 4.2+ so it's unclear how easy it will
be to support sprockets 4 and rails 4.2.  For now, we can use sprockets 3 and
have tests pass.
@jrafanie jrafanie changed the title Pin to sprockets 3 as 4.0 support will require some work Pin to sprockets 3 as 4.0 support will require some work (fix tests with rails 4.2) Nov 13, 2019
@cjlarose
Copy link
Member

#250 is still open an includes the same change. Alternatively, #251 drops support for Rails 4.2 and would obviate the need for this change.

@jrafanie
Copy link
Contributor Author

@cjlarose yeah, I'll leave this open and @pkuczynski can offer opinions:

I'm totally fine merging #250 and I can close this. Ultimately, I wanted to get #253 in and didn't want to include this change in it.

@pkuczynski
Copy link
Member

pkuczynski commented Jan 3, 2020

I think the way it was done in #256 is better as it only affects Rails 4.2

@pkuczynski pkuczynski closed this Jan 3, 2020
@pkuczynski pkuczynski added this to the 2.2.0 milestone Jan 3, 2020
@pkuczynski
Copy link
Member

I think the way it was done in #256 is better as it only affects Rails 4.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants