Add explicit implementation of Config::Options#as_json #292
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #287
Before,
Config::Options#as_json
was not explicitly defined, but the class included theEnumerable
module. So, if you were using ActiveSupport Core Extensions, then the definition of#as_json
for Enumerable was invoked, which would represent theConfig::Options
as a Array of key-value pairs instead of a Hash.This changes brings
#as_json
in line with the output we get fromto_json
: essentially, calling these methods on an instance ofConfig::Options
behaves the same as if they were called instead on the hash returned byto_hash
.It's not clear if this is a "bug fix" or a "breaking change" from a semver perspective, but I think it's unlikely that someone was depending on the output from
#as_json
to be the Array-of-pairs representation.