Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change "Diaper Acquisition" to "Diapers" in Annual survey #4686

Closed
2 tasks
cielf opened this issue Sep 30, 2024 · 1 comment · Fixed by #4702
Closed
2 tasks

Change "Diaper Acquisition" to "Diapers" in Annual survey #4686

cielf opened this issue Sep 30, 2024 · 1 comment · Fixed by #4702
Assignees
@sbpipb
Labels
Good First Issue Suitable for users that are newer or less experienced hacktoberfest

Comments

@cielf
Copy link
Collaborator

cielf commented Sep 30, 2024

Summary

Change "Diaper Acquisition" to "Diapers" in Annual survey

Why?

The section isn't not just acquisition, it's distribution as well

Details

The report is found by signing in as org_admin1@example.com, clicking on Reports, then Annual Survey, then a year. Recalculate the report to show a fresh copy.

Refactor the name of the underlying service from AcquisitionReportService to DiaperReportService

Todo

  • make text and refactoring changes as above
  • tests related to the annual survey still pass.
@cielf cielf added hacktoberfest Good First Issue Suitable for users that are newer or less experienced labels Sep 30, 2024
@sbpipb
Copy link
Collaborator

sbpipb commented Oct 3, 2024

i'd like to work on this @cielf assigning to myself

@sbpipb sbpipb self-assigned this Oct 3, 2024
@sbpipb sbpipb mentioned this issue Oct 3, 2024
Merged
@princekumarg12 princekumarg12 mentioned this issue Oct 8, 2024
Closed
dorner pushed a commit that referenced this issue Dec 14, 2024
@Benjamin-Couey
Resolves #4686 add another bank to seed (#4826)
49c9308 
* Added newline to end of file and removed unecessary whitespace

* Added basic information for new bank, partner, and associated users

* Added test for function that seeds organization with item with arbitrary name

* Implemented seed_random_item_with_name function

* Added a couple items unique to the new bank

* Updated request units to be seeded for all organizations

* Updated partners to be seeded with variable organizations and associated new partner with new bank

* Added StorageLocations for new bank, fixed typo

* Added Vendors for all orgs and added Purchases for new bank

* Added ProductDrives, ProductDriveParticipants, and Manufacturers for all orgs, removed redundant Product Drives section

* Added Donations and Distributions for the new bank, updating the way storage locations are selected to accommodate there being storage locations for multiple orgs

* Updated CONTRIBUTING.md docs to reflect the newly added bank

* Changes made by linter

* Changed records I updated to generate for all orgs to only generate for pdx_org and sc_org

* Updated bank and storage locations to use Faker

* Forgot to run linter on model files

* Added sections guaranteeing the items unique to the new bank are used for donations, purchases, distributions, and requests

* Added on_hand_minimum_quantity and on_hand_recommended_quantity for the new bank's items, guarantee that at least one of the items unique to the new bank has an inventory less than the recommended quantity

* Changed iterator name to be consistent with other uses of times.each

* Updated CONTRIBUTING.md docs to describe differences of each bank

* Moved seed_random_item_with_name from organization to seeds.rb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbpipb sbpipb

Labels
Good First Issue Suitable for users that are newer or less experienced hacktoberfest
Projects
None yet
Milestone
No milestone
2 participants
@sbpipb @cielf