Make dropdown lists alphabetical order ( Part 1) #4663
Conversation
| @@ -71,7 +71,6 @@ class User < ApplicationRecord | |||
| validate :password_complexity | |||
|
|
|||
| default_scope -> { kept } | |||
| scope :alphabetized, -> { order(discarded_at: :desc, name: :asc) } | |||
There was a problem hiding this comment.
This wasn't being used anywhere, so I opted to remove it and look to order user select fields on the instance vars defined in relevant controller files.
| include_blank: "", | ||
| collection: @items, | ||
| prompt: "Choose an item", | ||
| include_blank: false, # We've got a prompt, so no need for an include blank |
There was a problem hiding this comment.
I can remove this comment later, but I observed the item choice dropdown was showing some weird UI behavior, screenshot below of what I was seeing
There was a problem hiding this comment.
With the change, here is what it looks like. I think it looks a lot better, especially since this isn't a strict dropdown:
| @@ -10,7 +10,8 @@ | |||
| label: label, | |||
| error: error, | |||
| selected: storage_location_for_source(source.object), | |||
| include_blank: true, | |||
| include_blank: false, | |||
| prompt: "Choose a storage location", | |||
There was a problem hiding this comment.
Felt like this just looked better.
Before:
After:
db/seeds.rb
Outdated
| password_confirmation: 'password!' | ||
| password_confirmation: 'password!', | ||
| organization: user_data[:organization], # Any reason not to set this? | ||
| name: user_data[:email].split('@').first # Any reason not to set this? |
There was a problem hiding this comment.
Was there a reason why we weren't ensuring that an organization and name were in place for users?
There was a problem hiding this comment.
Once upon a time we needed organizations for bank users. We changed to a role-based access for all users so it is no longer needed. Super users and partners wouldn't have had an organization from the get-go. As for names, I think all the bank users in production have names, but not all the partner users do. Does that help?
There was a problem hiding this comment.
Ahhhh I see, that does help thank you! I'll get rid of these two additions and keep that in mind moving forward.
ajistrying
changed the title
|
Hey @ajistrying -- Just noticing this is still in draft, with no changes for awhile. It that the intent? |
Resolves #4663
Description
NOTE: Part of a multi-part effort to convert all relevant dropdown lists throughout the app to lower-case alphabetical order
There's a need to ensure that dropdown lists are ordered alphabetically by their lowercase options. I opted to go for tweaking existing
alphabetizedscopes where possible, and where that wasn't possible I would sort the list of options in place usually at the site of the instance variable being instantiated in the relevant controller.Type of change
This isn't a bug fix in the strict definition, more like a tweak to existing functionality.
How Has This Been Tested?
Screenshots