Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bootsnap #4853

Merged
merged 1 commit into from
Dec 14, 2024
Merged

Add bootsnap #4853

merged 1 commit into from
Dec 14, 2024

Conversation

coalest
Copy link
Collaborator

@coalest coalest commented Dec 13, 2024

Doesn't resolve any issue.

Description

The app boots up pretty slowly, takes me ~9 seconds in developent mode. This cuts bootup time by half for me locally.
This will be a nice improvement for development, because I often have to wait those ~10 seconds for the application to load just to run a test that takes a fraction of a second.

Type of change

  • Internal/dependencies

How Has This Been Tested?

Tested it locally. I'm not sure if there will be any issues with this in production or CI or codespaces.
But it not working will probably just mean that the boot time for the app is the same as it was before, so I don't think it's too risky.

Screenshots

Before and then after
image

@cielf cielf requested a review from dorner December 13, 2024 18:39
Copy link
Collaborator

@dorner dorner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give it a shot!

@dorner dorner merged commit dc37ff3 into rubyforgood:main Dec 14, 2024
11 checks passed
Copy link
Contributor

@coalest: Your PR Add bootsnap is part of today's Human Essentials production release: 2024.12.15.
Thank you very much for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants