This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
Don't incorrectly relativize sibling --path with the same prefix
#4715
+15
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given current working directory `/foo/app`, when you install with
`--path /foo/app_cache`, ensure that the messaging says:
Bundled gems are installed into /foo/app_cache
instead of the incorrect:
Bundled gems are installed into ._cache
|
Oof. Thanks for the fix! |
|
@homu r+ |
|
📌 Commit 2410d93 has been approved by |
homu
added a commit
that referenced
this pull request
Jun 25, 2016
Don't incorrectly relativize sibling `--path` with the same prefix
Given current working directory `/foo/app`, when you install with
`--path /foo/app_cache`, ensure that the messaging says:
Bundled gems are installed into /foo/app_cache
instead of the incorrect:
Bundled gems are installed into ._cache
|
☀️ Test successful - status |
segiddins
pushed a commit
that referenced
this pull request
Jun 27, 2016
Don't incorrectly relativize sibling `--path` with the same prefix
Given current working directory `/foo/app`, when you install with
`--path /foo/app_cache`, ensure that the messaging says:
Bundled gems are installed into /foo/app_cache
instead of the incorrect:
Bundled gems are installed into ._cache
(cherry picked from commit 3b928d8)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given current working directory
/foo/app, when you install with--path /foo/app_cache, ensure that the messaging says:instead of the incorrect: