Compare string value true
#4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub Actions booleans aren't… really… booleans. See: actions/runner#1483 I tripped on this [here](https://github.com/jgarber623/sprockets-sass_embedded/actions/runs/7361651564/job/20039226386) with a configuration like: ```yaml - uses: rubygems/release-gem@v1 with: await-release: false ``` This configuration is valid, but is ignored owing to the current configuration. This proposed change _should_ address that. The proposed change is consistent with behavior in other reusable actions (see [ruby/setup-ruby](https://github.com/ruby/setup-ruby), for instance).
Closed
|
Thanks for the merge, @segiddins! |
|
Posting here to confirm that this change did what we hoped it would do! A workflow file using this step: - uses: rubygems/release-gem@v1
with:
await-release: false…successfully skipped the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Actions booleans aren't… really… booleans.
See: actions/runner#1483
I tripped on this here with a configuration like:
This configuration is valid, but is ignored owing to the current configuration. This proposed change should address that.
The proposed change is consistent with behavior in other reusable actions (see ruby/setup-ruby, for instance).